alamb commented on code in PR #2528:
URL: https://github.com/apache/arrow-datafusion/pull/2528#discussion_r872615914
##########
datafusion/core/src/from_slice.rs:
##########
@@ -20,8 +20,8 @@
//! This file essentially exists to ease the transition onto arrow2
use arrow::array::{
- ArrayData, BinaryOffsetSizeTrait, BooleanArray, GenericBinaryArray,
- GenericStringArray, PrimitiveArray, StringOffsetSizeTrait,
+ ArrayData, BooleanArray, GenericBinaryArray, GenericStringArray,
OffsetSizeTrait,
Review Comment:
https://github.com/apache/arrow-rs/pull/1645/files
##########
ballista/rust/core/src/client.rs:
##########
@@ -131,11 +133,16 @@ impl BallistaClient {
struct FlightDataStream {
stream: Streaming<FlightData>,
schema: SchemaRef,
+ dictionaries_by_id: HashMap<i64, ArrayRef>,
Review Comment:
https://github.com/apache/arrow-rs/pull/1636
##########
datafusion/core/src/from_slice.rs:
##########
@@ -20,8 +20,8 @@
//! This file essentially exists to ease the transition onto arrow2
use arrow::array::{
- ArrayData, BinaryOffsetSizeTrait, BooleanArray, GenericBinaryArray,
- GenericStringArray, PrimitiveArray, StringOffsetSizeTrait,
+ ArrayData, BooleanArray, GenericBinaryArray, GenericStringArray,
OffsetSizeTrait,
Review Comment:
https://github.com/apache/arrow-rs/pull/1645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
