alamb commented on code in PR #2463:
URL: https://github.com/apache/arrow-datafusion/pull/2463#discussion_r872667686
##########
datafusion/core/src/optimizer/projection_push_down.rs:
##########
@@ -179,8 +180,12 @@ fn optimize_plan(
.map(|f| f.qualified_column())
.collect::<HashSet<Column>>();
+ let all_column_exprs = new_expr.iter().all(|e| matches!(e,
Expr::Column(_)));
Review Comment:
The only question I have here is "what if the column is in an `alias` or
something. However since the tests pass 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
