kou commented on code in PR #13157:
URL: https://github.com/apache/arrow/pull/13157#discussion_r873248362
##########
ci/scripts/java_jni_manylinux_build.sh:
##########
@@ -84,6 +84,7 @@ cmake \
-DARROW_PYTHON=${ARROW_PYTHON} \
-DARROW_RPATH_ORIGIN=${ARROW_RPATH_ORIGIN} \
-DARROW_SNAPPY_USE_SHARED=OFF \
+ -DARROW_S3=ON \
Review Comment:
Could you add `: ${ARROW_S3:=ON}` and use it as `-DARROW_S3=${ARROW_S3}`
like other variables such `ARROW_DATASET` and `ARROW_GANDIVA`.
##########
ci/docker/linux-apt-jni.dockerfile:
##########
@@ -61,6 +61,7 @@ RUN apt-get update -y -q && \
protobuf-compiler \
rapidjson-dev \
tzdata \
+ libcurl4-openssl-dev\
Review Comment:
Could you keep this list in alphabetical order?
##########
ci/docker/linux-apt-jni.dockerfile:
##########
@@ -82,6 +83,7 @@ ENV ARROW_BUILD_TESTS=OFF \
ARROW_PLASMA_JAVA_CLIENT=ON \
ARROW_PLASMA=ON \
ARROW_USE_CCACHE=ON \
+ ARROW_S3=ON \
Review Comment:
Could you keep this list in alphabetical order?
##########
ci/scripts/java_jni_manylinux_build.sh:
##########
@@ -84,6 +84,7 @@ cmake \
-DARROW_PYTHON=${ARROW_PYTHON} \
-DARROW_RPATH_ORIGIN=${ARROW_RPATH_ORIGIN} \
-DARROW_SNAPPY_USE_SHARED=OFF \
+ -DARROW_S3=ON \
Review Comment:
Could you keep this list in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
