kou commented on PR #13101: URL: https://github.com/apache/arrow/pull/13101#issuecomment-1127128748
In general, it's better that the Conda package for Windows provides CMake's package file. But I think that it's difficult because https://github.com/conda-forge/gtest-feedstock/blob/main/recipe/bld.bat mixes multiple CMake configurations. I think that a real fix for this is stopping `class ARROW_FLIGHT_EXPORT arrow::flight::FlightTest : public testing::Test` in https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/test_definitions.h that is introduced by #12499/ARROW-15707. (Cc: @lidavidm) If we implement shared tests by header only library, macro or something instead of shared library, we can use static library version of GoogleTest for `arrow_flight_testing.dll`. Anyway, I want to merge this workaround as soon as possible because this breaks our CI since 2022-05-07. (I should have checked carefully before I merge #13083/ARROW-16490.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
