alamb commented on code in PR #2537:
URL: https://github.com/apache/arrow-datafusion/pull/2537#discussion_r874139107
##########
ballista/rust/core/src/serde/logical_plan/mod.rs:
##########
@@ -1402,31 +1293,17 @@ mod roundtrip_tests {
#[tokio::test]
async fn roundtrip_logical_plan() -> Result<()> {
- let schema = Schema::new(vec![
- Field::new("id", DataType::Int32, false),
- Field::new("first_name", DataType::Utf8, false),
- Field::new("last_name", DataType::Utf8, false),
- Field::new("state", DataType::Utf8, false),
- Field::new("salary", DataType::Int32, false),
- ]);
-
- let plan = LogicalPlanBuilder::scan_csv(
- Arc::new(LocalFileSystem {}),
- "employee.csv",
- CsvReadOptions::new().schema(&schema).has_header(true),
- Some(vec![3, 4]),
- 4,
- )
- .await
- .and_then(|plan| plan.aggregate(vec![col("state")],
vec![max(col("salary"))]))
- .and_then(|plan| plan.build())
- .map_err(BallistaError::DataFusionError)?;
+ let plan = test_scan_csv("employee.csv", Some(vec![3, 4]))
+ .await?
+ .aggregate(vec![col("state")], vec![max(col("salary"))])?
+ .build()?;
roundtrip_test!(plan);
Ok(())
}
+ #[ignore] // see https://github.com/apache/arrow-datafusion/issues/2546
Review Comment:
FYI other reviewers: https://github.com/apache/arrow-datafusion/issues/2546
##########
ballista/rust/core/src/serde/logical_plan/mod.rs:
##########
@@ -1236,39 +1212,17 @@ mod roundtrip_tests {
#[tokio::test]
async fn roundtrip_analyze() -> Result<()> {
- let schema = Schema::new(vec![
Review Comment:
nice cleanups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
