alamb commented on code in PR #2523:
URL: https://github.com/apache/arrow-datafusion/pull/2523#discussion_r874152569
##########
datafusion/common/src/scalar.rs:
##########
@@ -934,16 +928,20 @@ impl ScalarValue {
match values {
Some(values) => {
// Push value for each field
- for c in 0..columns.len() {
- let column = columns.get_mut(c).unwrap();
- column.push(values[c].clone());
+ for (i, v) in
Review Comment:
All the better that removing a layer of `Box`ing lets clippy fix things more
easily 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
