westonpace commented on code in PR #12672: URL: https://github.com/apache/arrow/pull/12672#discussion_r874276425
########## python/pyarrow/_substrait.pyx: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# cython: language_level = 3 +from cython.operator cimport dereference as deref + +from pyarrow import Buffer +from pyarrow.lib cimport * +from pyarrow.includes.libarrow cimport * +from pyarrow.libarrow_substrait cimport * + + +def run_query(plan): + """ + Execute a Substrait plan and read the results as a RecordBatchReader. + + Parameters + ---------- + plan : Buffer + The serialized Substrait plan to execute. + """ + + cdef: + CResult[shared_ptr[CRecordBatchReader]] c_res_reader + shared_ptr[CRecordBatchReader] c_reader + RecordBatchReader reader + c_string c_str_plan + shared_ptr[CBuffer] c_buf_plan + + c_buf_plan = pyarrow_unwrap_buffer(plan) + c_res_reader = ExecuteSerializedPlan(deref(c_buf_plan)) Review Comment: `engine::DeserializePlan` can definitely trigger I/O because we are currently scanning glob patterns there in the calling thread. This could be improved someday but I think there is enough there at the moment to justify releasing the GIL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
