pitrou commented on code in PR #13101:
URL: https://github.com/apache/arrow/pull/13101#discussion_r874446229
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -25,27 +25,52 @@ if(WIN32)
list(APPEND ARROW_FLIGHT_LINK_LIBS ws2_32.lib)
endif()
-set(ARROW_FLIGHT_TEST_LINKAGE
- "${ARROW_TEST_LINKAGE}"
- PARENT_SCOPE)
+set(ARROW_FLIGHT_TEST_LINKAGE "${ARROW_TEST_LINKAGE}")
if(Protobuf_USE_STATIC_LIBS)
message(STATUS "Linking Arrow Flight tests statically due to static
Protobuf")
- set(ARROW_FLIGHT_TEST_LINKAGE
- "static"
- PARENT_SCOPE)
+ set(ARROW_FLIGHT_TEST_LINKAGE "static")
endif()
if(NOT ARROW_GRPC_USE_SHARED)
message(STATUS "Linking Arrow Flight tests statically due to static gRPC")
- set(ARROW_FLIGHT_TEST_LINKAGE
- "static"
- PARENT_SCOPE)
+ set(ARROW_FLIGHT_TEST_LINKAGE "static")
+endif()
+if(ARROW_TESTING)
+ if(WIN32)
Review Comment:
Hopefully this can be removed next in @lidavidm 's PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
