cyb70289 commented on PR #13164: URL: https://github.com/apache/arrow/pull/13164#issuecomment-1128671770
Thanks for the explanation @rouault . Instead of replacing `num_values` with `num_not_null`, does it make sense to reverse it? To replace `num_not_null` with `num_values`, and `num_null` with `null_count` (the function names are `IncrementNumValues` and `IncrementNullCount`). Will it make the code easier to reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
