dragosmg commented on code in PR #13163:
URL: https://github.com/apache/arrow/pull/13163#discussion_r874765215
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -493,11 +493,29 @@ register_bindings_datetime_parsers <- function() {
# each order is translated into possible formats
formats <- build_formats(orders)
+ x <- x$cast(string())
+
# make all separators (non-letters and non-numbers) into "-"
x <- call_binding("gsub", "[^A-Za-z0-9]", "-", x)
# collapse multiple separators into a single one
x <- call_binding("gsub", "-{2,}", "-", x)
+ # add a day (01) for "ym" and "my" orders
+ augmented_x <- NULL
+ if (any(orders %in% c("ym", "my"))) {
+ augmented_x <- call_binding("paste0", x, "-01")
+ }
+
+ augmented_x2 <- NULL
+ if (any(orders == "yq")) {
+ quarter_x <- call_binding("gsub", "^.*?-", "", x)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
