andygrove commented on PR #2549: URL: https://github.com/apache/arrow-datafusion/pull/2549#issuecomment-1129257522
> @alamb @andygrove is it required to add a new expression for Ballista? I did that in [218a917](https://github.com/apache/arrow-datafusion/pull/2549/commits/218a9177cd625990387ca183995b89bd489c5f5a), but I don't use it. Thanks I assume you had to add that to fix compilation issues because ballista has exhaustive matching of all expressions? The changes look reasonable to me. Note that we also have a `datafusion.proto` (in fact, we have two copies, as noted in https://github.com/apache/arrow-datafusion/issues/2514) that we should ideally also add new expressions to (but we have not been doing this consistently). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
