sanjibansg commented on code in PR #12852:
URL: https://github.com/apache/arrow/pull/12852#discussion_r875293847
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -16,7 +16,6 @@
// under the License.
#include "arrow/engine/substrait/extension_set.h"
-
Review Comment:
Made the change, thanks!
##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -226,14 +238,14 @@ class ARROW_ENGINE_EXPORT ExtensionSet {
private:
ExtensionIdRegistry* registry_;
/// The subset of extension registry URIs referenced by this extension set
- std::vector<util::string_view> uris_;
- std::vector<TypeRecord> types_;
-
- std::vector<FunctionRecord> functions_;
-
- // pimpl pattern to hide lookup details
- struct Impl;
- std::unique_ptr<Impl, void (*)(Impl*)> impl_;
+ std::unordered_map<uint32_t, util::string_view> uris_;
+ std::unordered_map<uint32_t, TypeRecord> types_;
+ std::unordered_map<uint32_t, FunctionRecord> functions_;
+ std::unordered_map<Id, uint32_t, IdHashEq, IdHashEq> types_map_,
functions_map_;
Review Comment:
Made the change, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
