nealrichardson commented on code in PR #13183:
URL: https://github.com/apache/arrow/pull/13183#discussion_r875999848
##########
r/R/io.R:
##########
@@ -292,7 +292,7 @@ make_readable_file <- function(file, mmap = TRUE,
compression = NULL, filesystem
file
}
-make_output_stream <- function(x, filesystem = NULL) {
+make_output_stream <- function(x, filesystem = NULL, compression = NULL) {
Review Comment:
One thing to watch out here: sometimes people name their parquet files
`something.parquet.snappy`, but you wouldn't use a CompressedOutputStream for
that, you'd pass the compression option to the parquet writer itself. I would
guess that the make_readable_file() path handles this already, maybe that can
be a model (or maybe it doesn't and needs to).
##########
r/R/io.R:
##########
@@ -301,6 +301,7 @@ make_output_stream <- function(x, filesystem = NULL) {
return(MakeRConnectionOutputStream(x))
}
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
