dragosmg commented on code in PR #13174:
URL: https://github.com/apache/arrow/pull/13174#discussion_r876001299
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -618,4 +618,40 @@ register_bindings_datetime_parsers <- function() {
for (ymd_order in ymd_parser_vec) {
register_binding(ymd_order, ymd_parser_map_factory(ymd_order))
}
+
+ register_binding("fast_strptime", function(x,
+ format,
+ tz = "UTC",
+ lt = FALSE,
+ cutoff_2000 = 68L) {
+ # `lt` controls the output `lt = TRUE` returns a POSIXlt (which doesn't
play
+ # well with mutate, for example)
+ if (lt) {
+ arrow_not_supported("`lt = TRUE` argument")
+ }
+
+ # TODO revisit once https://issues.apache.org/jira/browse/ARROW-16596 is
done
+ if (cutoff_2000 != 68L) {
+ arrow_not_supported("`cutoff_2000` != 68L argument")
+ }
Review Comment:
I think that is tested here:
https://github.com/dragosmg/arrow/blob/64230541b6cf5ebe3131a419b7dfb8a85fe8d5c8/r/tests/testthat/test-dplyr-funcs-datetime.R#L1891-L1909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
