vibhatha commented on PR #12672: URL: https://github.com/apache/arrow/pull/12672#issuecomment-1130131376
> If the user never tries to read from the reader then I would expect to get a segmentation fault: > > ``` > reader = substrait.run_query(buf) > del reader # This should segfault > ``` > > I think, without a close method, our only other option would be to ignore the error which seems even worse to me than a segfault. I see your point. That's bad, I agree. Shall we extend work on this and manage the Reader itself in this PR or should we block merging this until finalizing the Reader `close` PR and rebase this and merge. I prefer the latter. cc @pitrou @lidavidm @jorisvandenbossche -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
