emkornfield commented on a change in pull request #8109:
URL: https://github.com/apache/arrow/pull/8109#discussion_r483305734
##########
File path: cpp/src/arrow/util/decimal_test.cc
##########
@@ -113,7 +113,7 @@ TEST(DecimalTest, TestStringRoundTrip) {
(1ull << 63),
std::numeric_limits<uint64_t>::max(),
};
- static constexpr int32_t kScales[] = {-10, -1, 0, 1, 10};
+ static constexpr int32_t kScales[] = {0, 1, 10};
Review comment:
would it make sense to add another test how this code behaves when scale
is negative or is that already tested elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
