wjones127 commented on PR #13108: URL: https://github.com/apache/arrow/pull/13108#issuecomment-1130402961
> Is there any chance we could get rid of the pimpl pattern and just use a virtual class? I'm not sure what you mean by this. It seems like we want to have `Get()` return `opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>` if `#ifdef ARROW_WITH_OPENTELEMETRY`, but not expose that condition in the header file. Not sure how a virtual class helps hide that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
