jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483418021
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -987,22 +1009,23 @@ mod tests {
Ok(Arc::new(add(l, r)?))
});
- let my_add = ScalarFunction::new(
Review comment:
This is the main change to end users:
For most use-cases, `create_udf` is enough as it covers the common use-case
of "single signature", "single return type".
For all other use-cases, the user can use `ScalarFunction::new`.
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -987,22 +1009,23 @@ mod tests {
Ok(Arc::new(add(l, r)?))
});
- let my_add = ScalarFunction::new(
Review comment:
This is the main change to end users:
For most use-cases, `create_udf -> ScalarFunction` is enough as it covers
the common use-case of "single signature", "single return type".
For all other use-cases, the user can use `ScalarFunction::new`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
