AlenkaF commented on PR #13199: URL: https://github.com/apache/arrow/pull/13199#issuecomment-1132775935
Thanks @raulcd for reviewing and testing locally! For the first issue: `python -m pytest python/pyarrow/tests/` doesn't collect any tests which is correct. The skip of all the tests is added to the conftest file on purpose as this feature should only check the docstring examples in .py files and not the unit tests. Could you try to run `python -m pytest python/pyarrow/` and let me know how it goes? For the second issue. The errors that you get when removing newly added conftest file are due to the fact that doctest collects all the .py files from pyarrow to run doctest on. Because some modules were not build (in you case cuda for example) doctest complains. For this reason new conftest file was added, to check which modules are not installed and tell doctest to skip the files that are connected to this missing modules. The issue was solved by removing `--doctest--modules` from pytest setup because in that case doctest didn't run at all. So we need the conftest file to skip the files connected to the missing modules and then we should move `--doctest-modules` from pytest setup to a new job where we would add something similar to `pytest --doctest-modules python/pyarrow/`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
