jorgecarleitao commented on pull request #8113:
URL: https://github.com/apache/arrow/pull/8113#issuecomment-687528570
Great work and nice approach of going through the flamegraph. LGTM.
As a note, I ran DataFusion's benchmarks of this against master:
```
aggregate_query_no_group_by
time: [80.374 us 80.801 us 81.205 us]
change: [-2.8204% -0.7165% +1.3842%] (p = 0.56 >
0.05)
No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe
aggregate_query_group_by
time: [128.83 us 129.32 us 129.87 us]
change: [-5.1220% -3.0698% -1.0298%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
aggregate_query_group_by_with_filter
time: [204.17 us 204.46 us 204.77 us]
change: [-4.8251% -2.6720% -0.4294%] (p = 0.01 <
0.05)
Change within noise threshold.
Found 20 outliers among 100 measurements (20.00%)
9 (9.00%) high mild
11 (11.00%) high severe
```
If you think that there is a query that particularly benefits from this,
feel free to add it to the `arrow` cargo bench
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
