westonpace commented on PR #12672: URL: https://github.com/apache/arrow/pull/12672#issuecomment-1133142219
Can you revert 0ba47960ac0688b1cce3172cdb0fd51b8c05bb46 ? I think it only confuses things. Since `SubstraitSinkConsumer` is inside an internal namespace it is local to the file. If you wanted to make it more generally available you'd have to move it out of the file and add a header file. However, I don't think that is a good idea, per my comment above. Once that is reverted let's leave this alone and merge if green. I agree `run_query_as_reader` might be a good idea but let us defer that to a follow-up PR. This one is getting unwieldy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
