WillAyd commented on code in PR #12963:
URL: https://github.com/apache/arrow/pull/12963#discussion_r878559890
##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -174,6 +174,25 @@ class ARROW_EXPORT SelectKOptions : public FunctionOptions
{
std::vector<SortKey> sort_keys;
};
+/// \brief Rank options
+class ARROW_EXPORT RankOptions : public FunctionOptions {
+ public:
+ enum Tiebreaker { Min, Max, First, Dense };
+
+ explicit RankOptions(SortOrder order = SortOrder::Ascending,
+ NullPlacement null_placement = NullPlacement::AtEnd,
+ Tiebreaker = RankOptions::First);
+ static constexpr char const kTypeName[] = "RankOptions";
+ static RankOptions Defaults() { return RankOptions(); }
+
+ /// Sorting order
+ SortOrder order;
Review Comment:
Went ahead and did this. Right now with `ArrayRankOptions` I think we'd also
have to register something like `array_rank` to actually be able to use it. Not
sure if we want to implement that, keep things as is for consistency with
`ArraySortOptions` or just remove `ArrayRankOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
