tustvold commented on code in PR #2572:
URL: https://github.com/apache/arrow-datafusion/pull/2572#discussion_r878690223
##########
datafusion/core/src/datasource/file_format/mod.rs:
##########
@@ -63,8 +67,9 @@ pub trait FileFormat: Send + Sync + fmt::Debug {
/// TODO: should the file source return statistics for only columns
referred to in the table schema?
async fn infer_stats(
&self,
- reader: Arc<dyn ObjectReader>,
+ store: &dyn ObjectStore,
Review Comment:
Predominantly to avoid being one of the implementations "that might need an
`Arc<ObjectStore>`". I didn't see a compelling reason why this method would
need a "ownable" reference, but given the rest of the codebase is pretty
hard-coded to `Arc<dyn ObjectStore>` I don't feel strongly. Will change back
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
