jorgecarleitao opened a new pull request #8117:
URL: https://github.com/apache/arrow/pull/8117


   This PR:
   
   * adds a benchmark to StringArray's `try_from(Vec<Option<&str>>)`
   * Replaces `TryFrom` by `From`
   * improves performance by 50% by not using `StringBuilder`
   * adds the same functionality to `LargeStringArray` (through a macro)
   
   Benchmarks on my computer:
   ```
   array_string_from_vec 128                                                    
                         
                           time:   [3.4717 us 3.4818 us 3.4928 us]
                           change: [-52.364% -51.639% -50.913%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 5 outliers among 100 measurements (5.00%)
     1 (1.00%) high mild
     4 (4.00%) high severe
   
   array_string_from_vec 256                                                    
                         
                           time:   [4.9325 us 4.9397 us 4.9475 us]
                           change: [-52.324% -51.120% -50.268%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 10 outliers among 100 measurements (10.00%)
     1 (1.00%) low mild
     2 (2.00%) high mild
     7 (7.00%) high severe
   
   array_string_from_vec 512                                                    
                         
                           time:   [7.3873 us 7.4032 us 7.4204 us]
                           change: [-51.805% -51.144% -50.502%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 10 outliers among 100 measurements (10.00%)
     3 (3.00%) high mild
     7 (7.00%) high severe
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to