tustvold commented on code in PR #1719:
URL: https://github.com/apache/arrow-rs/pull/1719#discussion_r878742794
##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -65,7 +67,7 @@ pub struct ArrowWriter<W: ParquetWriter> {
max_row_group_size: usize,
}
-impl<W: 'static + ParquetWriter> ArrowWriter<W> {
+impl<W: Write> ArrowWriter<W> {
Review Comment:
This seemingly small change means you can pass in `&mut
std::io::Cursor<Vec<_>>` or any other construction which makes this much easier
to use
##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -744,15 +748,15 @@ mod tests {
let expected_batch =
RecordBatch::try_new(schema.clone(), vec![Arc::new(a),
Arc::new(b)]).unwrap();
- let cursor = InMemoryWriteableCursor::default();
+ let mut cursor = Cursor::new(vec![]);
Review Comment:
:tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
