andygrove commented on code in PR #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588#discussion_r878892214
##########
datafusion/sql/src/planner.rs:
##########
@@ -4868,36 +4835,36 @@ mod tests {
#[test]
fn test_offset_no_limit() {
let sql = "SELECT id FROM person WHERE person.id > 100 OFFSET 5;";
- let expected = "Offset: 5\
- \n Projection: #person.id\
- \n Filter: #person.id > Int64(100)\
- \n TableScan: person projection=None";
+ let expected = "Offset: 3\
+ \n Limit: 5\
+ \n Projection: #person.id\
+ \n Filter: #person.id > Int64(100)\
+ \n TableScan: person projection=None";
quick_test(sql, expected);
}
#[test]
- fn test_offset_after_limit_with_limit_push() {
Review Comment:
We shouldn't be testing optimizer rules here, just the SQL query planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
