vibhatha commented on code in PR #13150:
URL: https://github.com/apache/arrow/pull/13150#discussion_r879476405
##########
r/R/query-engine.R:
##########
@@ -121,11 +119,13 @@ ExecPlan <- R6Class("ExecPlan",
x
})
}
+ target_names <- names(.data$aggregations)
+ for (i in seq_len(length(target_names))) {
+ .data$aggregations[[i]][["name"]] <-
.data$aggregations[[i]][["target"]] <- target_names[i]
Review Comment:
Ah my_bad, I should have added an affix here.
The idea of this PR was to simplify the usage of `AggregateNodeOptions`. In
that case, (referring to the JIRA) we thought it is better to put what is
relevant to an aggregation within the object itself. It is not always the same,
you're correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
