alamb commented on code in PR #1720:
URL: https://github.com/apache/arrow-rs/pull/1720#discussion_r880499706
##########
arrow/src/compute/kernels/concat.rs:
##########
@@ -102,6 +102,25 @@ pub fn concat(arrays: &[&dyn Array]) -> Result<ArrayRef> {
Ok(make_array(mutable.freeze()))
}
+// Elementwise concatenation of StringArrays
+pub fn string_concat<Offset: OffsetSizeTrait>(
Review Comment:
I also agree that a new string (or `utf8` module) would be good here.
There are a bunch of other potential candidates in datafusion to move into
arrow-rs (kudos to @ovr for implementing many of them initially):
https://github.com/apache/arrow-datafusion/blob/master/datafusion/physical-expr/src/string_expressions.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
