jorisvandenbossche commented on a change in pull request #8115:
URL: https://github.com/apache/arrow/pull/8115#discussion_r484311322



##########
File path: python/pyarrow/array.pxi
##########
@@ -802,6 +802,12 @@ cdef class Array(_PandasConvertible):
         """
         return _pc().call_function('sum', [self])
 
+    def mode(self):
+        """
+        Compute the mode of valuesd in a numerical array.
+        """
+        return _pc().call_function('mode', [self])

Review comment:
       I am not sure we necessarily want to add it as a Array method as well. 
For a starter, it's also not a method on a numpy array (so convenient 
consistency with numpy is already not an argument). In general we don't expose 
all compute functions also as methods (but currently the line is not very clear 
... )




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to