[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2602: Remove `ExecutionProps` from `OptimizerRule` trait

[GitBox]

andygrove commented on code in PR #2602:
URL: https://github.com/apache/arrow-datafusion/pull/2602#discussion_r880628979


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1253,12 +1253,14 @@ impl SessionState {
                 .register_catalog(config.default_catalog.clone(), 
default_catalog);
         }
 
+        let execution_props = ExecutionProps::new();
+
         SessionState {
             session_id,
             optimizers: vec![
                 // Simplify expressions first to maximize the chance
                 // of applying other optimizations
-                Arc::new(SimplifyExpressions::new()),
+                Arc::new(SimplifyExpressions::new(execution_props.clone())),

Review Comment:
   ~This is not correct. We need the same `ExecutionProps` to be shared between 
`SessionState` and `SimplifyExpressions` so that they both have the same 
execution start time. ~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org