paddyhoran commented on pull request #8116: URL: https://github.com/apache/arrow/pull/8116#issuecomment-688252444
Hey @jorgecarleitao, Sorry, my info was wrong. As you said `<From<Vec<_>>` does do a full copy of the underlying data which uses memory.rs [here](https://github.com/apache/arrow/blob/master/rust/arrow/src/buffer.rs#L274). I was not aware of this. I think you are right that there are a lot of improvements to be made to the builders, we should be able to get better performance out of them as they should be able to act like a `Vec` where the correct alignment is enforced so that no copy is needed. Anyway, sorry for the noise and thank you for the detailed explanation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
