lidavidm commented on code in PR #13109: URL: https://github.com/apache/arrow/pull/13109#discussion_r882041136
########## python/pyarrow/tests/test_compute.py: ########## @@ -1702,6 +1702,18 @@ def test_logical(): def test_cast(): + arr = pa.array([1, 2, 3, 4], type='int64') + options = pc.CastOptions() + + with pytest.raises(ValueError): + pc.cast(arr, target_type=None) + + with pytest.raises(ValueError): + pc.cast(arr, 'int32', safe=True, options=options) + + with pytest.raises(ValueError): + pc.cast(arr, 'int32', safe=False, options=options) + Review Comment: Thanks for testing the error cases, can we also test that the non-error case now works with cast options? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
