thisisnic commented on code in PR #13190:
URL: https://github.com/apache/arrow/pull/13190#discussion_r882560057
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -50,49 +50,70 @@ test_df <- tibble::tibble(
test_that("strptime", {
t_string <- tibble(x = c("2018-10-07 19:04:05", NA))
t_stamp <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05"), NA))
+ t_stamp_with_pm_tz <- tibble(
+ x = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz = "Pacific/Marquesas"),
NA)
+ )
+
+ withr::with_timezone("Pacific/Marquesas", {
Review Comment:
Please can you chuck in a comment above this set of tests as to why we're
using `expect_equal()` and not `compare_dplyr_binding()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
