alamb commented on code in PR #1739:
URL: https://github.com/apache/arrow-rs/pull/1739#discussion_r883016153
##########
arrow/src/ipc/reader.rs:
##########
@@ -287,24 +287,22 @@ fn create_primitive_array(
let array_data = match data_type {
Utf8 | Binary | LargeBinary | LargeUtf8 => {
// read 3 buffers
- let mut builder = ArrayData::builder(data_type.clone())
+ ArrayData::builder(data_type.clone())
Review Comment:
👍 the new pattern certainly look nicer in my opinion
##########
arrow/src/compute/kernels/string.rs:
##########
@@ -74,15 +74,11 @@ pub fn string_concat<Offset: OffsetSizeTrait>(
output_offsets.append(Offset::from_usize(output_values.len()).unwrap());
}
- let mut builder =
Review Comment:
Since this code is moved, this PR now has a conflict sadly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
