kou commented on code in PR #12914:
URL: https://github.com/apache/arrow/pull/12914#discussion_r883410722
##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -37,6 +37,34 @@ if(ARROW_GCS)
Boost::system)
endif()
+if(ARROW_AZURE)
+ set(AZURE_SRCS)
+ list(APPEND
+ AZURE_SRCS
+ azurefs_mock.cc
+ azurefs.cc)
+
+ add_arrow_lib(azurefs
+ SOURCES
+ ${AZURE_SRCS}
+ SHARED_LINK_LIBS
+ ${ARROW_LINK_LIBS}
+ SHARED_PRIVATE_LINK_LIBS
+ ${ARROW_SHARED_PRIVATE_LINK_LIBS}
+ STATIC_LINK_LIBS
+ ${ARROW_STATIC_LINK_LIBS})
+
+ set_target_properties(azurefs_objlib PROPERTIES CXX_STANDARD 14
CXX_STANDARD_REQUIRED ON)
Review Comment:
I think that @pitrou said that we can use C++14 features in
`cpp/src/arrow/filesystem/azurefs*.cc` but we must not use C++14 features in
other `*.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
