nevi-me commented on PR #1746:
URL: https://github.com/apache/arrow-rs/pull/1746#issuecomment-1139545653

   Worth advertising @tustvold @alamb is at least 30% improvement in the writer 
due to this PR
   
   ```rust
   write_batch primitive/4096 values primitive                                  
                                           
                           time:   [1.1237 ms 1.1270 ms 1.1303 ms]
                           thrpt:  [156.08 MiB/s 156.54 MiB/s 156.99 MiB/s]
                    change:
                           time:   [-29.494% -28.991% -28.501%] (p = 0.00 < 
0.05)
                           thrpt:  [+39.863% +40.828% +41.831%]
                           Performance has improved.
   Found 5 outliers among 100 measurements (5.00%)
     1 (1.00%) high mild
     4 (4.00%) high severe
   write_batch primitive/4096 values primitive non-null                         
                                                   
                           time:   [979.35 us 982.76 us 986.33 us]
                           thrpt:  [178.86 MiB/s 179.51 MiB/s 180.13 MiB/s]
                    change:
                           time:   [-30.346% -29.722% -29.002%] (p = 0.00 < 
0.05)
                           thrpt:  [+40.849% +42.291% +43.567%]
                           Performance has improved.
   Found 7 outliers among 100 measurements (7.00%)
     3 (3.00%) high mild
     4 (4.00%) high severe
   write_batch primitive/4096 values bool                                       
                                     
                           time:   [62.749 us 63.655 us 64.860 us]
                           thrpt:  [17.527 MiB/s 17.859 MiB/s 18.116 MiB/s]
                    change:
                           time:   [-33.845% -32.730% -31.281%] (p = 0.00 < 
0.05)
                           thrpt:  [+45.520% +48.655% +51.159%]
                           Performance has improved.
   Found 1 outliers among 100 measurements (1.00%)
     1 (1.00%) high severe
   write_batch primitive/4096 values bool non-null                              
                                               
                           time:   [40.799 us 40.848 us 40.901 us]
                           thrpt:  [27.793 MiB/s 27.830 MiB/s 27.863 MiB/s]
                    change:
                           time:   [-45.958% -45.620% -45.294%] (p = 0.00 < 
0.05)
                           thrpt:  [+82.796% +83.891% +85.043%]
                           Performance has improved.
   Found 10 outliers among 100 measurements (10.00%)
     4 (4.00%) high mild
     6 (6.00%) high severe
   write_batch primitive/4096 values string                                     
                                       
                           time:   [627.92 us 634.23 us 642.61 us]
                           thrpt:  [123.85 MiB/s 125.49 MiB/s 126.75 MiB/s]
                    change:
                           time:   [-23.875% -23.318% -22.771%] (p = 0.00 < 
0.05)
                           thrpt:  [+29.486% +30.408% +31.362%]
                           Performance has improved.
   Found 11 outliers among 100 measurements (11.00%)
     8 (8.00%) high mild
     3 (3.00%) high severe
   write_batch primitive/4096 values string non-null                            
                                                
                           time:   [617.66 us 618.60 us 619.56 us]
                           thrpt:  [128.46 MiB/s 128.66 MiB/s 128.86 MiB/s]
                    change:
                           time:   [-26.558% -25.760% -25.150%] (p = 0.00 < 
0.05)
                           thrpt:  [+33.601% +34.699% +36.162%]
                           Performance has improved.
   Found 6 outliers among 100 measurements (6.00%)
     1 (1.00%) low mild
     2 (2.00%) high mild
     3 (3.00%) high severe
   
   Benchmarking write_batch nested/4096 values primitive list: Warming up for 
3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 6.4s, enable flat sampling, or reduce sample count to 60.
   write_batch nested/4096 values primitive list                                
                                             
                           time:   [1.2680 ms 1.2695 ms 1.2709 ms]
                           thrpt:  [128.87 MiB/s 129.01 MiB/s 129.16 MiB/s]
                    change:
                           time:   [-33.645% -33.420% -33.197%] (p = 0.00 < 
0.05)
                           thrpt:  [+49.694% +50.195% +50.705%]
                           Performance has improved.
   Found 14 outliers among 100 measurements (14.00%)
     1 (1.00%) low severe
     6 (6.00%) low mild
     2 (2.00%) high mild
     5 (5.00%) high severe
   Benchmarking write_batch nested/4096 values primitive list non-null: Warming 
up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 8.2s, enable flat sampling, or reduce sample count to 50.
   write_batch nested/4096 values primitive list non-null                       
                                                      
                           time:   [1.6240 ms 1.6347 ms 1.6475 ms]
                           thrpt:  [117.49 MiB/s 118.41 MiB/s 119.19 MiB/s]
                    change:
                           time:   [-29.010% -28.463% -27.890%] (p = 0.00 < 
0.05)
                           thrpt:  [+38.676% +39.788% +40.866%]
                           Performance has improved.
   Found 13 outliers among 100 measurements (13.00%)
     8 (8.00%) high mild
     5 (5.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to