ethe commented on code in PR #2643: URL: https://github.com/apache/arrow-datafusion/pull/2643#discussion_r884249187
########## datafusion/core/src/lib.rs: ########## @@ -14,6 +14,7 @@ // KIND, either express or implied. See the License for the // specific language governing permissions and limitations // under the License. +#![feature(generic_associated_types)] Review Comment: I am not sure about the compiler version requirement of datafusion, but if we need a pluggable async executor, it should be better to have a higher rank type support, or we have to take some runtime effects like `Pin<Box<Output>>` in `Future` output handling ########## datafusion/core/src/lib.rs: ########## @@ -14,6 +14,7 @@ // KIND, either express or implied. See the License for the // specific language governing permissions and limitations // under the License. +#![feature(generic_associated_types)] Review Comment: I am not sure about the compiler version requirement of datafusion, but if we need a pluggable async executor, it should be better to have a higher rank type support, or we have to take some runtime overheads like `Pin<Box<Output>>` in `Future` output handling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
