cyb70289 commented on code in PR #13250:
URL: https://github.com/apache/arrow/pull/13250#discussion_r884388340
##########
cpp/src/arrow/io/buffered_test.cc:
##########
@@ -293,6 +293,15 @@ TEST_F(TestBufferedOutputStream, Tell) {
ASSERT_OK(buffered_->Close());
+ // write long bytes after raw_pos is cached
+ const std::string basic_string = "1234568790";
+ OpenBuffered(/*buffer_size=*/3, false);
Review Comment:
Last nit comment :)
`false` looks not necessary. If you think it's important, please also add
`/*append=*/false`, boolean variables are hard to reason from caller side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
