lidavidm commented on code in PR #13205:
URL: https://github.com/apache/arrow/pull/13205#discussion_r885727602
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -390,4 +390,11 @@ Result<std::shared_ptr<RecordBatchReader>>
RecordBatchReader::Make(
return std::make_shared<SimpleRecordBatchReader>(std::move(batches), schema);
}
+RecordBatchReader::~RecordBatchReader() {
+ auto st = this->Close();
+ if (!st.ok()) {
+ ARROW_LOG(WARNING) << "Implicityly called Close, but failed with " <<
st.message();
Review Comment:
```suggestion
ARROW_LOG(WARNING) << "Implicitly called RecordBatchReader::Close
failed: " << st.ToString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
