wjones127 commented on code in PR #13206:
URL: https://github.com/apache/arrow/pull/13206#discussion_r886185955


##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -130,6 +130,9 @@ struct ARROW_EXPORT S3Options {
   /// Whether OutputStream writes will be issued in the background, without 
blocking.
   bool background_writes = true;
 
+  /// Whether to allow creation of new buckets
+  bool allow_create_buckets = false;

Review Comment:
   I liked `create_buckets` but since there is a setter method and I want it 
named the same thing as the property (for clear error hints), I felt like 
`allow_bucket_creation` was the better choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to