raulcd commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r886853056
##########
dev/archery/archery/release.py:
##########
@@ -390,7 +390,7 @@ def commits(self):
commit_range = f"{lower}..{upper}"
return list(map(Commit, self.repo.iter_commits(commit_range)))
- def curate(self):
+ def curate(self, minimal):
Review Comment:
this will fail on line 421 as we are calling `self.curate()` without any
argument and you are expecting one now. One way of avoiding this on python is
specifying a default that maintains previous behaviour:
```suggestion
def curate(self, minimal=False):
```
Whith this we avoid the failure.
##########
dev/archery/archery/release.py:
##########
@@ -412,7 +412,7 @@ def curate(self):
if key not in within_keys]
return ReleaseCuration(release=self, within=within, outside=outside,
Review Comment:
I would have expected `ReleaseCuration` to require a new field `minimal`
defined. Line 244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
