tustvold commented on issue #1750: URL: https://github.com/apache/arrow-rs/issues/1750#issuecomment-1144494306
> But It will cause the inconsistency between bixed_fields and self.data.child_data, which means StructArray::column(self, 0) != make_array(self.data.child_data()[0])? We have the same "inconsistency" on other array types, e.g. `GenericStringArray::value_offsets` or `PrimitiveArray::values`. I personally don't think this is a problem. > I don't find StructArray::slice in the c++ implementation Yeah this is just a usability thing, the Rust implementation is just calling through to `make_array(self.data_ref().slice(offset, length))`. > everything is pushed down to Buffer and Bitmap I would definitely support this change, and it would be the better long-term solution. It has been discussed at length, all that really remains is someone to volunteer to do it :sweat_smile:. The only outstanding sticking point has been handling offsets for BooleanArrays, but I don't imagine there would be resistance to special casing these as a Bitmap in ArrayData... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
