HashidaTKS commented on code in PR #13279: URL: https://github.com/apache/arrow/pull/13279#discussion_r888081188
########## csharp/src/Apache.Arrow/Arrays/Time64Array.cs: ########## @@ -0,0 +1,191 @@ +// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using Apache.Arrow.Types; +using System; +using System.IO; + +namespace Apache.Arrow +{ + /// <summary> + /// The <see cref="Time64Array"/> class holds an array of longs, where each value is + /// stored as the number of seconds/ milliseconds (depending on the Time64Type) since midnight. + /// </summary> + public class Time64Array : PrimitiveArray<long> + { + /// <summary> + /// The <see cref="Builder"/> class can be used to fluently build <see cref="Time64Array"/> objects. + /// </summary> + public class Builder : PrimitiveArrayBuilder<long, long, Time64Array, Builder> Review Comment: Does `Builder` need to inherit `PrimitiveArrayBuilder<TFrom, TTo, TArray, TBuilder>`? Can we directly use `PrimitiveArrayBuilder<T, TArray, TBuilder>` (`PrimitiveArrayBuilder<long, Time64Array, Builder>`) if `ConvertTo` does nothing? It is similar for `Time32Array.Builder` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
