rtpsw commented on code in PR #13252:
URL: https://github.com/apache/arrow/pull/13252#discussion_r888658433
##########
cpp/src/arrow/compute/registry_test.cc:
##########
@@ -85,5 +95,137 @@ TEST_F(TestRegistry, Basics) {
ASSERT_EQ(func, f2);
}
+INSTANTIATE_TEST_SUITE_P(
+ TestRegistry, TestRegistry,
+ testing::Values(
+ std::make_tuple(
+ static_cast<MakeFunctionRegistry>([]() { return
FunctionRegistry::Make(); }),
+ []() { return 0; }, []() { return std::vector<std::string>{}; },
"default"),
+ std::make_tuple(
+ static_cast<MakeFunctionRegistry>([]() {
+ return FunctionRegistry::Make(GetFunctionRegistry());
+ }),
+ []() { return GetFunctionRegistry()->num_functions(); },
+ []() { return GetFunctionRegistry()->GetFunctionNames(); },
"nested")));
+
+TEST(TestRegistry, RegisterTempFunctions) {
+ auto default_registry = GetFunctionRegistry();
+ constexpr int rounds = 3;
+ for (int i = 0; i < rounds; i++) {
+ auto registry = FunctionRegistry::Make(default_registry);
+ for (std::string func_name : {"f1", "f2"}) {
+ std::shared_ptr<Function> func = std::make_shared<ScalarFunction>(
+ func_name, Arity::Unary(), /*doc=*/FunctionDoc::Empty());
+ ASSERT_OK(registry->CanAddFunction(func));
+ ASSERT_OK(registry->AddFunction(func));
+ ASSERT_RAISES(KeyError, registry->CanAddFunction(func));
+ ASSERT_RAISES(KeyError, registry->AddFunction(func));
+ ASSERT_OK(default_registry->CanAddFunction(func));
+ }
+ }
+}
+
+TEST(TestRegistry, RegisterTempAliases) {
+ auto default_registry = GetFunctionRegistry();
+ std::vector<std::string> func_names = default_registry->GetFunctionNames();
+ constexpr int rounds = 3;
+ for (int i = 0; i < rounds; i++) {
+ auto registry = FunctionRegistry::Make(default_registry);
+ for (std::string func_name : func_names) {
+ std::string alias_name = "alias_of_" + func_name;
+ std::shared_ptr<Function> func = std::make_shared<ScalarFunction>(
+ func_name, Arity::Unary(), /*doc=*/FunctionDoc::Empty());
+ ASSERT_RAISES(KeyError, registry->GetFunction(alias_name));
+ ASSERT_OK(registry->CanAddAlias(alias_name, func_name));
+ ASSERT_OK(registry->AddAlias(alias_name, func_name));
+ ASSERT_OK(registry->GetFunction(alias_name));
+ ASSERT_OK(default_registry->GetFunction(func_name));
+ ASSERT_RAISES(KeyError, default_registry->GetFunction(alias_name));
+ }
+ }
+}
+
+template <int N>
Review Comment:
I'll use `kExampleSeqNum`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
