andygrove commented on code in PR #2549:
URL: https://github.com/apache/arrow-datafusion/pull/2549#discussion_r888917283
##########
datafusion/expr/src/expr.rs:
##########
@@ -99,6 +99,15 @@ pub enum Expr {
/// Right-hand side of the expression
right: Box<Expr>,
},
+ /// A binary expression such as "age > 21"
+ AnyExpr {
+ /// Left-hand side of the expression
+ left: Box<Expr>,
+ /// The comparison operator
+ op: Operator,
+ /// Right-hand side of the expression
+ right: Box<Expr>,
Review Comment:
The definition of `AnyExpr` here is identical to the definition of
`BinaryExpr`. I wonder if it would be better to use `BinaryExpr` for
consistency and model Any as `AnyExpr(Expr)` to just model the right-hand side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
