alamb commented on code in PR #1782:
URL: https://github.com/apache/arrow-rs/pull/1782#discussion_r889003153
##########
parquet/src/arrow/mod.rs:
##########
@@ -96,12 +96,9 @@
//! # writer.close().unwrap();
//!
//! let file = File::open("data.parquet").unwrap();
-//! let file_reader = SerializedFileReader::new(file).unwrap();
//!
-//! let file_metadata = file_reader.metadata().file_metadata();
-//! let mask = ProjectionMask::leaves(file_metadata.schema_descr(), [0]);
-//!
-//! let mut arrow_reader = ParquetFileArrowReader::new(Arc::new(file_reader));
+//! let mut arrow_reader = ParquetFileArrowReader::try_new(file).unwrap();
Review Comment:
👍
##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -145,15 +145,28 @@ impl ArrowReader for ParquetFileArrowReader {
}
impl ParquetFileArrowReader {
- /// Create a new [`ParquetFileArrowReader`]
+ /// Create a new [`ParquetFileArrowReader`] with the provided
[`ChunkReader`]
Review Comment:
```suggestion
/// Create a new [`ParquetFileArrowReader`] with the provided
[`ChunkReader`],
/// such as a `std::io::File`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
