icexelloss commented on code in PR #13028:
URL: https://github.com/apache/arrow/pull/13028#discussion_r889135333
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -361,6 +361,19 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
Expression filter;
};
+class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
+ public:
+ AsofJoinNodeOptions(FieldRef time, FieldRef keys, int64_t tolerance)
+ : time(std::move(time)), keys(std::move(keys)), tolerance(tolerance) {}
+
+ // time column
Review Comment:
I added tests for the unsupported types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
