alamb commented on issue #1779: URL: https://github.com/apache/arrow-rs/issues/1779#issuecomment-1146591354
> The scale field within DataType::Decimal should be signed I agree > The documentation should refer to scale as an exponent, and not potentially misleading notions of decimal points and digits I am not sure about this -- I think the documentation could be clarified but talking about scale/exponent/mantissa is not appropriate for fixed width representation (they are floating point concepts) > DecimalArray::value shouldn't be applying the scale to the value at all Definitely worth discussing -- I suspect some people would like `DecimalArray` to convert to `f64` and some would like to do the conversion themselves. I can see a need for access to the raw `i128` as well as a conversion > We should probably audit the other places that interpret decimal values for consistency 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
