tustvold commented on code in PR #1791:
URL: https://github.com/apache/arrow-rs/pull/1791#discussion_r889966156


##########
parquet/src/file/metadata.rs:
##########
@@ -223,6 +223,7 @@ pub struct RowGroupMetaData {
     num_rows: i64,
     total_byte_size: i64,
     schema_descr: SchemaDescPtr,
+    // Todo add filter result -> row range

Review Comment:
   > page index stored in file-meta level.
   
   It isn't even file-meta level, it isn't part of the footer but stored as 
separate pages :sweat_smile: 
   
   > It was just a simple idea at first, maybe we can find a better way in the 
process of implementation
   
   Provided we take care to ensure we keep things pub(crate) so we don't break 
APIs, this seems like a good strategy :+1:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to