pitrou commented on code in PR #13282: URL: https://github.com/apache/arrow/pull/13282#discussion_r890170156
########## cpp/src/arrow/util/int_util.h: ########## @@ -21,6 +21,7 @@ #include <type_traits> #include "arrow/status.h" +#include "arrow/util/int_util_overflow.h" Review Comment: Hmm, then `CheckSliceParams` can go to `int_util_overflow.h` probably? What I meant above is that we don't want `Windows.h` to be included from our public headers, even transitively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
